Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add usage guidelines for waku content topics #117

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

chaitanyaprem
Copy link
Contributor

@chaitanyaprem chaitanyaprem commented Dec 17, 2024

Included a small section on usage guidelines for waku content topics.

It was observed that in status communities these guidelines were not followed which is being fixed based on discussion post.
Hence adding an explicit section will help app developers design content-topics accordingly.

@chaitanyaprem
Copy link
Contributor Author

@jimstir no clue why linter is showing errors even though the files that have been changed in this PR have none. Maybe we can fix the CI action to only show errors on files that have been touched (added/updated) in the PR.

@jimstir
Copy link
Collaborator

jimstir commented Dec 17, 2024

@jimstir no clue why linter is showing errors even though the files that have been changed in this PR have none. Maybe we can fix the CI action to only show errors on files that have been touched (added/updated) in the PR.

We thought about this but have decided that all markdown files in this repo should follow markdown-linting rules, so any errors should be addressed. Do not worry about the linter, the errors displaying here are being addressed here.

waku/informational/23/topics.md Outdated Show resolved Hide resolved
waku/informational/23/topics.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

waku/informational/23/topics.md Outdated Show resolved Hide resolved
waku/informational/23/topics.md Outdated Show resolved Hide resolved
@chaitanyaprem chaitanyaprem force-pushed the content-topic-usage branch 2 times, most recently from 5a85dd3 to 0971b52 Compare January 2, 2025 12:12
update communities spec as per content topic changes (#118)

- Update content topic usage as per
https://forum.vac.dev/t/status-communities-review-and-proposed-usage-of-waku-content-topics/335
- Update symmetric encryption done at content topic level before
messages are handed over to waku
- Update about shard or pubsub topic usage
@chaitanyaprem chaitanyaprem merged commit dc7497a into main Jan 2, 2025
2 checks passed
@chaitanyaprem chaitanyaprem deleted the content-topic-usage branch January 2, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants